rok commented on code in PR #50874:
URL: https://github.com/apache/arrow/pull/50874#discussion_r3842949030
##########
cpp/src/arrow/extension/tensor_extension_array_test.cc:
##########
@@ -244,16 +244,16 @@ TEST_F(TestFixedShapeTensorType,
MetadataSerializationRoundtrip) {
// Validate permutation member must be an array with integer values
Review Comment:
Let's make sure the checks are robust for such cases.
```suggestion
// Validate permutation member must be an array with integer values
CheckDeserializationRaises(
ext_type_, storage_type, R"({"shape":[3,4],"permutation":[]})",
"Invalid permutation");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
