Copilot commented on code in PR #50874:
URL: https://github.com/apache/arrow/pull/50874#discussion_r3843775927
##########
cpp/src/arrow/extension/tensor_internal.h:
##########
@@ -56,4 +52,19 @@ Result<std::shared_ptr<Buffer>> SliceTensorBuffer(const
Array& data_array,
const DataType& value_type,
std::span<const int64_t>
shape);
+Result<simdjson::dom::object> ParseJsonObject(simdjson::dom::parser& parser,
+ const std::string& json);
+
+Result<std::optional<simdjson::dom::element>> GetOptionalJsonField(
+ const simdjson::dom::object& object, std::string_view key);
Review Comment:
GH-50901 and the PR description explicitly require the simdjson On-Demand
API, but these new helpers expose `simdjson::dom` types and both deserializers
construct a DOM parser. This misses the migration requirement and fully
materializes metadata instead of using the existing On-Demand helpers. Please
implement these helpers around `simdjson::ondemand::{parser,object,value}`
(including padded input) and update both deserializers accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
