mhilton commented on code in PR #10840:
URL: https://github.com/apache/arrow-rs/pull/10840#discussion_r3854121728
##########
arrow-schema/src/datatype_display.rs:
##########
@@ -478,7 +481,7 @@ mod tests {
let values_field = Arc::new(Field::new("values", DataType::Int32,
true));
let ree_data_type = DataType::RunEndEncoded(run_ends_field.clone(),
values_field.clone());
let ree_data_type_string = ree_data_type.to_string();
- let expected_string = "RunEndEncoded(\"run_ends\": non-null UInt32,
\"values\": Int32)";
+ let expected_string = "RunEndEncoded('run_ends': UInt32, \"values\":
Int32)";
Review Comment:
I'd suggest picking one type of quote mark to use for this string.
##########
arrow-schema/src/datatype_display.rs:
##########
@@ -174,10 +174,13 @@ impl Display for DataType {
}
Self::RunEndEncoded(run_ends_field, values_field) => {
write!(f, "RunEndEncoded(")?;
- let run_ends_str = format_field(run_ends_field);
let values_str = format_field(values_field);
- write!(f, "{run_ends_str}, {values_str})")?;
+ write!(
Review Comment:
Out of interest is there some reason that you chose to encode this as
`RunEndEncoded('run_ends': Int32, "values": String)` rather than the more
succinct `RunEndEncoded(Int32, String)`. This looks to be more akin to a
Dictionary than anything else, and those use a form more like the latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
