Jefffrey commented on code in PR #10835:
URL: https://github.com/apache/arrow-rs/pull/10835#discussion_r3889545328
##########
arrow-array/src/ffi.rs:
##########
@@ -1192,6 +1192,65 @@ mod tests_to_then_from_ffi {
Ok(())
}
+ #[test]
+ fn test_struct_array_sliced_by_producer() -> Result<()> {
Review Comment:
i was more imagining an actual c++/pyarrow integration; as this test is, it
does the same as `test_slice_struct_data_with_existing_offset` but just with
extra roundtrip steps through ffi
i think its better to remove this test if we're not going to have an
explicit c++/pyarrow test, as we can already mock the data structure they
create as we did in `test_slice_struct_data_with_existing_offset`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
