jaideeppyne commented on code in PR #10835:
URL: https://github.com/apache/arrow-rs/pull/10835#discussion_r3890117147


##########
arrow-array/src/ffi.rs:
##########
@@ -1192,6 +1192,65 @@ mod tests_to_then_from_ffi {
         Ok(())
     }
 
+    #[test]
+    fn test_struct_array_sliced_by_producer() -> Result<()> {

Review Comment:
   Agreed, removed. Without a real producer on the other side it was building 
the same shape as `test_slice_struct_data_with_existing_offset` and then 
pushing it through ffi, so it was not testing the boundary, just costing a 
round trip.
   
   `ffi.rs` is untouched by the PR now. The import I had added for it is gone 
too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to