zhangxinyao88 commented on PR #10923: URL: https://github.com/apache/arrow-rs/pull/10923#issuecomment-5486477668
> [what benchmarks are these numbers coming from?](https://github.com/apache/arrow-rs/pull/10923#issuecomment-5475037332) Those were from local runs of `arrow-avro/benches/decoder.rs` on my Mac. I used Criterion's saved baselines to compare this branch against `main`. The GKE results don't match mine, and I trust those more. They show small regressions in the paths changed by this PR, so I'll remove the local numbers from the description. Looking at it again, `OffsetBufferBuilder` already stores its offsets in a `Vec`, so this case is different from the other callsites in #10245. I'm leaning toward closing this unless you think the cleanup is still worth keeping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
