andygrove commented on a change in pull request #334:
URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r636129329
##########
File path: ballista/rust/core/src/serde/logical_plan/from_proto.rs
##########
@@ -75,6 +76,33 @@ impl TryInto<LogicalPlan> for &protobuf::LogicalPlanNode {
.build()
.map_err(|e| e.into())
}
+ LogicalPlanType::Window(window) => {
+ let input: LogicalPlan = convert_box_required!(window.input)?;
+ let window_expr = window
+ .window_expr
+ .iter()
+ .map(|expr| expr.try_into())
+ .collect::<Result<Vec<_>, _>>()?;
+
+ // let partition_by_expr = window
+ // .partition_by_expr
+ // .iter()
+ // .map(|expr| expr.try_into())
+ // .collect::<Result<Vec<_>, _>>()?;
+ // let order_by_expr = window
+ // .order_by_expr
+ // .iter()
+ // .map(|expr| expr.try_into())
+ // .collect::<Result<Vec<_>, _>>()?;
+ // // FIXME parse the window_frame data
Review comment:
It looks this is still WIP? Is the plan to complete this as part of this
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
