jorgecarleitao commented on pull request #334:
URL: https://github.com/apache/arrow-datafusion/pull/334#issuecomment-845151947


   I haven't had the time to go through yet;
   
   Since this is a large decomposable change, a suggestion here is to create a 
branch and merge this on that branch, so that we do not have incomplete 
features in master and allow PRs to that branch without an issue. Then merge 
the branch into master once its first iteration is ready (e.g. logical and 1 
physical plan).
   
   (This is something that I wished to have when implementing large features; 
it gives the time to review in parts without the risk of having incomplete code 
in master)
   
   With that said, I am also fine risk it and merg to master; @Jimexist do you 
have any preference how would you prefer to work on this here? :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to