HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r3900624997
##########
cpp/src/parquet/statistics.h:
##########
@@ -89,6 +93,11 @@ class TypedComparator : public Comparator {
/// elements with accompanying bitmap indicating which elements are
/// included (bit set) and excluded (bit not set)
///
+ /// For floating-point types with ColumnOrder::TYPE_DEFINED_ORDER, NaNs are
Review Comment:
No. I think the comments at `std::pair<T, T> GetMinMax(const ::arrow::Array&
values)` tell the user not to use it on float/double arrays.
```cpp
/// \brief Compute minimum and maximum elements from an Arrow array. Only
/// valid for certain Parquet Type / Arrow Type combinations, like
BYTE_ARRAY
/// / arrow::BinaryArray
```
##########
cpp/src/parquet/statistics.h:
##########
@@ -89,6 +93,11 @@ class TypedComparator : public Comparator {
/// elements with accompanying bitmap indicating which elements are
/// included (bit set) and excluded (bit not set)
///
+ /// For floating-point types with ColumnOrder::TYPE_DEFINED_ORDER, NaNs are
Review Comment:
No. I think the comments at `std::pair<T, T> GetMinMax(const ::arrow::Array&
values)` tell the users not to use it on float/double arrays.
```cpp
/// \brief Compute minimum and maximum elements from an Arrow array. Only
/// valid for certain Parquet Type / Arrow Type combinations, like
BYTE_ARRAY
/// / arrow::BinaryArray
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
