HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r3902513615


##########
cpp/src/arrow/dataset/file_parquet_test.cc:
##########
@@ -974,6 +975,95 @@ TEST(TestParquetStatistics, NoNullCount) {
   }
 }
 
+template <typename T>
+void TestNaNCount(const std::shared_ptr<DataType>& type,
+                  const ::parquet::schema::NodePtr& parquet_node) {
+  auto field = ::arrow::field("x", type);
+  auto dataset_schema = ::arrow::schema({field});
+  ::parquet::ColumnDescriptor descr(parquet_node, 0, 0);

Review Comment:
   These cases just calculate on the statistics but don't depend on the column 
order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to