Jefffrey commented on PR #10944: URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5503075496
> benchmarks shows a minor 3-4% improvement when I ran this locally with array sizes `8192`. this PR serves as the final step for #10945 are we sure this isnt noise? from what i see in this PR, the generic isnt actually being threaded in to be `false` anywhere also side note, i do wonder the impact of this on codegen. i know we introduced it in previous PRs, but @alamb did raise a recent epic (in datafusion) about binary size, and this is likely to contribute to a larger binary now if we thread in `false` for the generic (though to what degree im not sure) - https://github.com/apache/datafusion/issues/24727 just something to think about 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
