Rich-T-kid commented on PR #10944: URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5503826313
> are we sure this isnt noise? from what i see in this PR, the generic isn't actually being threaded in to be false anywhere this is true, it could be noise. when I ran the benchmarks locally I did switch out the true for false before/after running the benchmarks to compare > just something to think about 🤔 I will keep this in mind. I think seeing the performance difference between the two variants will give us the best guide on weather or not its worth introducing the extra code. #10945 should have this once I can get the benchmarks bot working -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
