Copilot commented on code in PR #45001:
URL: https://github.com/apache/arrow/pull/45001#discussion_r3917047167
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -860,6 +860,7 @@ if(ARROW_COMPUTE)
compute/kernels/scalar_arithmetic.cc
compute/kernels/scalar_boolean.cc
compute/kernels/scalar_compare.cc
+ compute/kernels/scalar_hash.cc
compute/kernels/scalar_if_else.cc
Review Comment:
`scalar_hash.cc` is added to the CMake source list, but the Meson build’s
`arrow_compute_lib_sources` in `cpp/src/arrow/meson.build` doesn’t include
`compute/kernels/scalar_hash.cc`. Since `compute/initialize.cc` now calls
`internal::RegisterScalarHash`, Meson builds are likely to fail at link time
unless the new source is added there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
