kszucs commented on code in PR #45001:
URL: https://github.com/apache/arrow/pull/45001#discussion_r3917260741
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -860,6 +860,7 @@ if(ARROW_COMPUTE)
compute/kernels/scalar_arithmetic.cc
compute/kernels/scalar_boolean.cc
compute/kernels/scalar_compare.cc
+ compute/kernels/scalar_hash.cc
compute/kernels/scalar_if_else.cc
Review Comment:
Good catch, and it went further than the comment — fixed in 63fe3f3bc2.
Confirmed `scalar_hash` appeared in **zero** meson.build files while CMake
had three entries, and since `initialize.cc` calls `RegisterScalarHash`
unconditionally a Meson build would compile the caller without the definition
and fail to link.
Four new sources needed wiring, not just the library one:
- `compute/kernels/scalar_hash.cc` → `cpp/src/arrow/meson.build`
- `scalar_hash_test.cc` → `arrow-compute-scalar-utility-test` in
`kernels/meson.build` (matching CMake's placement)
- `scalar_hash_benchmark` → `scalar_kernel_benchmarks` in
`kernels/meson.build`
- `key_hash_benchmark.cc` → `cpp/src/arrow/compute/meson.build`, which the
suppressed note missed; it's also new in this PR and had no Meson entry either
Used `dependencies: [arrow_benchmark_dep]` for the key-hash benchmark since
`arrow_benchmark_dep` already pulls in `gtest_dep`, which is all `ASSERT_OK`
needs — consistent with the neighbouring `function_benchmark`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
