emkornfield commented on code in PR #50916:
URL: https://github.com/apache/arrow/pull/50916#discussion_r3921828149
##########
cpp/src/parquet/properties.h:
##########
@@ -1157,7 +1157,9 @@ class PARQUET_EXPORT ArrowReaderProperties {
list_type_(kArrowDefaultListType),
arrow_extensions_enabled_(false),
should_load_statistics_(false),
- smallest_decimal_enabled_(false) {}
+ smallest_decimal_enabled_(false),
+ convert_flba_timestamps_(false),
Review Comment:
I think it is probably more useful to default this to true, most timestamps
will likely be in a range that is handle-able, and if the intent is for it to
be timestamp then I think this makes a better end-user experience. CC @wgtmac
@pitrou do you have a preference here?
Keeping the clamp_on_overflow to false makes sense to me because otherwise
it is potential corruption/data-loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
