emkornfield commented on code in PR #50916:
URL: https://github.com/apache/arrow/pull/50916#discussion_r3921876339
##########
cpp/src/parquet/arrow/reader_internal.cc:
##########
@@ -855,6 +856,49 @@ Status TransferHalfFloat(RecordReader* reader, MemoryPool*
pool,
return Status::OK();
}
+// Read a TIMESTAMP-annotated FLBA(12) column as a 64-bit Arrow timestamp.
Values that do
+// not fit in the 64 bit range either error or clamp to min/max int64,
depending on
+// configuration.
+Status TransferFlbaTimestamp(RecordReader* reader, MemoryPool* pool,
+ const std::shared_ptr<Field>& field, Datum* out,
+ bool clamp_on_overflow) {
+ static const auto binary_type = ::arrow::fixed_size_binary(12);
+ std::shared_ptr<ChunkedArray> chunked_array;
+ RETURN_NOT_OK(
Review Comment:
Do we really need to transfer here, can't we read with the underlying reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
