prtkgaur commented on code in PR #48345: URL: https://github.com/apache/arrow/pull/48345#discussion_r3921390089
########## cpp/src/parquet/decoder.cc: ########## @@ -35,6 +35,9 @@ #include "arrow/array/builder_dict.h" #include "arrow/array/builder_primitive.h" #include "arrow/type_traits.h" +#include "arrow/util/alp/alp.h" Review Comment: `decoder.cc` is down to one, `alp_codec_internal.h`; it had been pulling in three. What removed the other two is that the decoder no longer derives anything itself — it takes the page's value count from `AlpCodec::DecodeElementCount` rather than computing it from `AlpConstants` and the header layout, so the codec header is the only one it needs. `encoder.cc` still has a second include, for `AlpConstants::kAlpVectorSize`, the writer's fixed vector size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
