prtkgaur commented on code in PR #48345:
URL: https://github.com/apache/arrow/pull/48345#discussion_r3921390020
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -2475,5 +2475,89 @@ TYPED_TEST(TestBloomFilterWriter, Basic) {
}
}
+// ----------------------------------------------------------------------
+// ALP Encoding Tests for Float/Double Columns
+// ----------------------------------------------------------------------
+
+using TestFloatValuesWriter = TestPrimitiveWriter<FloatType>;
+using TestDoubleValuesWriter = TestPrimitiveWriter<DoubleType>;
+
+TEST_F(TestFloatValuesWriter, RequiredAlpEncoding) {
Review Comment:
Added, and it reproduces the bug you flagged in the same review — the
all-null page was writing a zero-byte payload, which is your `FlushValues`
comment below.
The helper writes an optional column with V2 pages and leading nulls, so the
definition levels and the value buffer disagree by a known amount. Four tests
use it: float and double with a few nulls, and both with every value null,
which is the empty-buffer case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
