Jimexist commented on a change in pull request #334:
URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r636557518
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -2641,13 +2701,23 @@ mod tests {
}
#[test]
- fn over_not_supported() {
+ fn empty_over() {
let sql = "SELECT order_id, MAX(order_id) OVER () from orders";
- let err = logical_plan(sql).expect_err("query should have failed");
- assert_eq!(
- "NotImplemented(\"Unsupported OVER clause ()\")",
- format!("{:?}", err)
- );
+ let expected = "\
+ Projection: #order_id, #MAX(order_id)\
+ \n WindowAggr: windowExpr=[[MAX(#order_id)]] partitionBy=[],
orderBy=[]\
+ \n TableScan: orders projection=None";
+ quick_test(sql, expected);
+ }
+
+ #[test]
+ fn empty_over_plus() {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
