Jimexist commented on pull request #334: URL: https://github.com/apache/arrow-datafusion/pull/334#issuecomment-845188351
> I went over this PR quite carefully. Thank you very much @Jimexist for the contribution! ❤️ > ❤️ -- this PR looks to be in great shape. > > All I think this PR needs is a few more tests and it could be merged in. > > I am not familiar with the ballista code, but it looked ok to me. @andygrove do you have any suggestions of who might be interested in those changes? thanks for the comment! @andygrove I am not 100% sure of the `oneof` usage in the `window_frame` field, so I guess that's one place to look at. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
