Cintu07 commented on code in PR #10981:
URL: https://github.com/apache/arrow-rs/pull/10981#discussion_r3933453939
##########
arrow-string/src/concat_elements.rs:
##########
@@ -219,11 +219,17 @@ pub fn concat_elements_fixed_size_binary(
))
})?;
let output_size = left_size + right_size;
+ let output_value_length = i32::try_from(output_size).map_err(|_| {
+ ArrowError::InvalidArgumentError(format!(
+ "Concatenated FixedSizeBinary value length {output_size} exceeds
{}",
+ i32::MAX
Review Comment:
pushed in 7a3b559. kept {output_size} and dropped the constant. if you
prefer your
version as written, let me know and i will push that instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
