Cintu07 commented on code in PR #10981:
URL: https://github.com/apache/arrow-rs/pull/10981#discussion_r3933429981
##########
arrow-string/src/concat_elements.rs:
##########
@@ -219,11 +219,17 @@ pub fn concat_elements_fixed_size_binary(
))
})?;
let output_size = left_size + right_size;
+ let output_value_length = i32::try_from(output_size).map_err(|_| {
+ ArrowError::InvalidArgumentError(format!(
+ "Concatenated FixedSizeBinary value length {output_size} exceeds
{}",
+ i32::MAX
Review Comment:
yeah fair, 2147483647 reads as noise.
heads up though, the test asserts the whole string so the suggestion alone
reds ci.
i'll fix test_fixed_size_binary_concat_width_overflow in the same commit
either way.
only bit i'd keep is {output_size}, that one's the caller's own width not a
constant,
so it says which pair blew up when it comes through concat_elements_dyn. so
"value length {output_size} exceeds i32". happy to take yours as written
though, say
which and i'll push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
