sdf-jkl opened a new pull request, #11016: URL: https://github.com/apache/arrow-rs/pull/11016
# Which issue does this PR close? - Closes #6897. # Rationale for this change rustfmt does not discover out-of-line modules declared inside macros (rust-lang/rustfmt#3253). The experimental module macro therefore causes cargo fmt to skip several Parquet module trees. This uses the same approach as delta-io/delta-kernel-rs#935. # What changes are included in this PR? - Replace experimental module macro declarations with explicit, mutually exclusive feature-gated declarations while preserving visibility and documentation behavior. - Remove the separate Parquet formatting workaround from CI. - Remove the workaround from the contributor documentation and use the standard workspace formatting command. # Are these changes tested? - cargo fmt --all -- --check - cargo check -p parquet - cargo check -p parquet --all-features - cargo test -p parquet --lib encodings::rle (15 passed) - Verbose cargo fmt output confirms that the formerly skipped module trees are traversed. A full cargo test -p parquet --lib run compiled successfully and passed 1,278 tests; 93 fixture-dependent tests could not run because the local checkout does not have the testing and parquet-testing data submodules initialized. # Are there any user-facing changes? Contributors can now format all Parquet sources with the standard cargo fmt --all command. There are no public API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
