Rich-T-kid commented on code in PR #11016: URL: https://github.com/apache/arrow-rs/pull/11016#discussion_r3954197518
########## CONTRIBUTING.md: ########## @@ -159,13 +159,6 @@ PR be sure to run the following and check for lint issues: cargo +stable fmt --all -- --check ``` -Note that currently the above will not check all source files in the parquet crate. To check all -parquet files run the following from the top-level `arrow-rs` directory: - -```bash -cargo fmt -p parquet -- --check --config skip_children=true `find ./parquet -name "*.rs" \! -name format.rs` -``` - Review Comment: nice ########## parquet/src/encodings/mod.rs: ########## @@ -20,4 +20,10 @@ pub mod decoding; pub mod encoding; pub mod levels; -experimental!(pub(crate) mod rle); +// Keep this module declaration explicit so rustfmt discovers its source file. +// See the comment in the crate root. +#[cfg(feature = "experimental")] +#[doc(hidden)] +pub mod rle; +#[cfg(not(feature = "experimental"))] +pub(crate) mod rle; Review Comment: why is this here twice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
