PlenoraETL commented on PR #11020: URL: https://github.com/apache/arrow-rs/pull/11020#issuecomment-5585739393
Thanks for the review — all five points addressed, branch force-pushed. - Dropped the comment above the fix and the doc comment on the test. - Renamed to `test_invalid_dictionary_batch_without_data` and moved it down, next to `test_missing_buffer_metadata_error`. - Removed the committed `.arrow` file: the test now builds the malformed `DictionaryBatch` in memory with `FlatBufferBuilder`, following the shape of `test_missing_buffer_metadata_error`. It calls `read_dictionary` directly, so there's no file and no byte-patching involved. `cargo test -p arrow-ipc` passes (132 / 7 / 11) and clippy is clean. One note in case it matters to you: I had to `#[allow(deprecated)]` on `Field::new_dict`, since `read_dictionary` looks the field up by dict id and that's the constructor that sets one. Happy to build the schema differently if there's a preferred way now that dict ids are on their way out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
