PlenoraETL commented on PR #11020: URL: https://github.com/apache/arrow-rs/pull/11020#issuecomment-5593105447
Good catch — no, it wasn't necessary. `Field::new` works here: `dict_id` defaults to 0, which is what `fields_with_dict_id(0)` looks for, so the deprecated constructor was only adding noise (and an `#[allow]`). Applied your suggestion and dropped the `#[allow(deprecated)]` with it. `cargo test -p arrow-ipc` still passes (132 / 7 / 11) and clippy is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
