tadeja commented on PR #50195: URL: https://github.com/apache/arrow/pull/50195#issuecomment-5604683037
uf, grande changes, thanks @raulcd! Here some hopefully useful pointers from my end using the last CI log [Docker Test conda-cpp](https://github.com/ursacomputing/crossbow/actions/runs/34340290734/job/102429226249#step:7:788) at line 784 ```shell -- Providing CMake module for FindAWSSDKAlt as part of Arrow CMake package ``` -> A) It looks like AWS dependency remains with core Arrow instead of "ArrowS3 CMake package" during configure there? at 2454 ```shell -- Installing: /opt/conda/envs/arrow/lib/cmake/Arrow/FindAWSSDKAlt.cmake ``` -> B) Here `FindAWSSDKAlt.cmake` is installed into cmake/Arrow - Doesn't it need to move to cmake/ArrowS3 ? at 2472 ```shell -- Installing: /opt/conda/envs/arrow/lib/cmake/ArrowS3/ArrowS3Config.cmake -- Installing: /opt/conda/envs/arrow/lib/cmake/ArrowS3/ArrowS3ConfigVersion.cmake -- Installing: /opt/conda/envs/arrow/lib/cmake/ArrowS3/ArrowS3Targets.cmake ``` C) One more issue - installed `ArrowS3Targets.cmake` defines targets with no `INTERFACE_LINK_LIBRARIES` Can be run in conda-cpp container after `cpp_build.sh`: ```shell grep -c INTERFACE_LINK_LIBRARIES /opt/conda/envs/arrow/lib/cmake/ArrowS3/ArrowS3Targets.cmake ``` `0` That isn't visible in current CI jobs, but could be verified in CI with the following additions, after discussions with 🤖 Fable, and committed here https://github.com/apache/arrow/commit/da9f9476f737dcb8a18fb94ec1d41b120b92586e ... See if it is useful for you to add changes along those lines to `test-conda-cpp` to see the failure here on PR too ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
