tadeja commented on code in PR #50195: URL: https://github.com/apache/arrow/pull/50195#discussion_r3982331537
########## cpp/src/arrow/CMakeLists.txt: ########## Review Comment: Should [this remaining ARROW_S3 section](https://github.com/raulcd/arrow/blob/142e154f01c995e1089ccf20b92f913fcde7c1d2/cpp/src/arrow/CMakeLists.txt#L100-L114) get an update now? I've tried it locally on top of PR changes, seems OK; ```diff diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt @@ -111,22 +111,6 @@ if(ARROW_USE_GLOG) endif() endif() -if(ARROW_S3) - if(AWSSDK_SOURCE STREQUAL "SYSTEM") - list(APPEND - ARROW_STATIC_INSTALL_INTERFACE_LIBS - aws-cpp-sdk-identity-management - aws-cpp-sdk-sts - aws-cpp-sdk-cognito-identity - aws-cpp-sdk-s3 - aws-cpp-sdk-core) - elseif(AWSSDK_SOURCE STREQUAL "BUNDLED") - if(UNIX) - list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl) - endif() - endif() -endif() if(ARROW_WITH_OPENTELEMETRY) @@ -1070,6 +1054,10 @@ if(ARROW_FILESYSTEM) if(AWSSDK_SOURCE STREQUAL "SYSTEM") list(APPEND ARROW_S3_STATIC_INSTALL_INTERFACE_LIBS ${AWSSDK_LINK_LIBRARIES}) + elseif(AWSSDK_SOURCE STREQUAL "BUNDLED") + if(UNIX) + list(APPEND ARROW_S3_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl) + endif() endif() add_arrow_lib(arrow_s3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
