Copilot commented on code in PR #51269:
URL: https://github.com/apache/arrow/pull/51269#discussion_r3973636388
##########
cpp/src/parquet/properties_test.cc:
##########
@@ -44,6 +45,22 @@ TEST(TestReaderProperties, Basics) {
ASSERT_FALSE(props.page_checksum_verification());
}
+TEST(TestReaderProperties, SetMemoryPool) {
+ ReaderProperties props;
+ ASSERT_EQ(props.memory_pool(), ::arrow::default_memory_pool());
+
+ ::arrow::MemoryPool* custom_pool = ::arrow::system_memory_pool();
+ props.set_memory_pool(custom_pool);
+ ASSERT_EQ(props.memory_pool(), custom_pool);
Review Comment:
This test may be ineffective on builds where `default_memory_pool()` is
already the system pool (so `system_memory_pool()` == `default_memory_pool()`),
making the assertions pass without actually verifying that `set_memory_pool()`
changes anything. Use a distinct pool instance (e.g., `ProxyMemoryPool`) so the
pointer value is guaranteed to differ from the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
