pitrou commented on code in PR #51269:
URL: https://github.com/apache/arrow/pull/51269#discussion_r3976385344
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -68,47 +68,25 @@ parquet::ReaderProperties MakeReaderProperties(
const ParquetFileFormat& format, ParquetFragmentScanOptions*
parquet_scan_options,
const std::string& path = "", std::shared_ptr<fs::FileSystem> filesystem =
nullptr,
MemoryPool* pool = default_memory_pool()) {
- // FIXME (GH-51264): Can't mutate pool after ReaderProperties construction.
- parquet::ReaderProperties properties(pool);
- if (parquet_scan_options->reader_properties->is_buffered_stream_enabled()) {
- properties.enable_buffered_stream();
- } else {
- properties.disable_buffered_stream();
- }
-
properties.set_buffer_size(parquet_scan_options->reader_properties->buffer_size());
- properties.set_footer_read_size(
- parquet_scan_options->reader_properties->footer_read_size());
-
- auto file_decryption_prop =
- parquet_scan_options->reader_properties->file_decryption_properties();
+ parquet::ReaderProperties properties =
*parquet_scan_options->reader_properties;
+ properties.set_memory_pool(pool);
Review Comment:
I think we need to unset `read_dense_for_nullable` as it wasn't set before?
What do you think @wgtmac ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
