HuaHuaY commented on code in PR #51266:
URL: https://github.com/apache/arrow/pull/51266#discussion_r3976023995
##########
cpp/src/gandiva/engine.cc:
##########
@@ -183,6 +185,26 @@ void AddAbsoluteSymbol(llvm::orc::LLJIT& lljit, const
std::string& name,
llvm::cantFail(std::move(error));
}
+void AddNativeBoolZExtAttrs(llvm::Function& function) {
Review Comment:
According to https://llvm.org/docs/LangRef.html, we should also handle other
attributes, but I would prefer to leave that for a separate PR later if someone
needs.
> ABI attributes must be specified both at the function
declaration/definition and call-site, otherwise the behavior may be undefined.
ABI attributes cannot be safely dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
