HuaHuaY commented on PR #51266: URL: https://github.com/apache/arrow/pull/51266#issuecomment-5615121864
My AI provided two pieces of feedback, and I agree with its points: 1. The current changes break compatibility with LLVM 7. 2. There is another code path in `cpp/src/gandiva/decimal_ir.cc` that calls `CreateCall` and also requires copying the attributes. I will submit another commit shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
