pitrou commented on code in PR #51270:
URL: https://github.com/apache/arrow/pull/51270#discussion_r3977399125
##########
cpp/src/arrow/acero/test_nodes.cc:
##########
@@ -274,7 +274,7 @@ struct GatedNode : public ExecNode, public TracedNode {
}
GatedNode(ExecPlan* plan, std::vector<ExecNode*> inputs,
- std::shared_ptr<Schema> output_schema, const GatedNodeOptions&
options)
+ const std::shared_ptr<Schema>& output_schema, const
GatedNodeOptions& options)
Review Comment:
This seems wrong too: the `ExecNode` constructor takes `output_schema` by
value. So the change should instead be to add a `std::move`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
