pitrou commented on PR #51270: URL: https://github.com/apache/arrow/pull/51270#issuecomment-5616100882
Hi @hsutter , I'm not doing a full review for now. I've just looked at a few changes in diff view order and found deficiencies in how the AI reasoned about the code. I'm especially surprised that such a simple pattern as passing a constructor arg by value and then moving it to an instance attribute has not been suggested. Also in some cases the intention is clearly to store the `shared_ptr` for lifetime purposes (for example when returning a lambda or iterator). I think this shows that a bit more human-driven effort is required to get this to a desirable end state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
