pitrou commented on code in PR #51237:
URL: https://github.com/apache/arrow/pull/51237#discussion_r3977516570
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -1245,7 +1245,7 @@ TYPED_TEST(TestStringKernels, Utf8Normalize) {
// decomposed: U+0061(LATIN SMALL LETTER A) + U+0301(COMBINING ACUTE ACCENT)
// composed: U+00E1(LATIN SMALL LETTER A WITH ACUTE)
- const char* json_composed = "[\"foo\", \"á\"]";
+ const char* json_composed = "[\"foo\", \"\xc3\xa1\"]";
Review Comment:
I think keeping the bytes values make it clearer what the test is doing (and
prevent the mistake that is being fixed here :-)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
