pitrou commented on code in PR #51237:
URL: https://github.com/apache/arrow/pull/51237#discussion_r3977536598
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -1260,6 +1260,25 @@ TYPED_TEST(TestStringKernels, Utf8Normalize) {
&options);
}
+ // Hangul composes algorithmically in utf8proc, not through the composition
table.
Review Comment:
Is this comment useful? This is mentioning an implementation detail of
utf8proc, which doesn't seem relevant for our purposes.
(I've checked that Python agreed with this behavior)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
