fornwall commented on code in PR #50513:
URL: https://github.com/apache/arrow/pull/50513#discussion_r3994111637
##########
cpp/src/arrow/compute/kernels/vector_hash_test.cc:
##########
@@ -403,6 +403,44 @@ TEST_F(TestHashKernel, DictEncodeBoolean) {
ArrayFromJSON(boolean(), "[true]"), ArrayFromJSON(int32(), "[0, null,
0]"));
}
+// float16 is not part of PrimitiveTypes(), so it is not covered by
+// TestHashKernelPrimitive above and gets its own coverage here. Like float32
and
+// float64, it is hashed by its raw bit pattern.
Review Comment:
That made a lot of sense - did that in
723f3f95f6b841acd4e207613150979fb0beefea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
