Reranko05 commented on code in PR #50513:
URL: https://github.com/apache/arrow/pull/50513#discussion_r4009438557
##########
cpp/src/arrow/compute/kernels/vector_hash.cc:
##########
@@ -700,6 +701,13 @@ void AddHashKernels(VectorFunction* func, VectorKernel
base, OutputType out_ty)
DCHECK_OK(func->AddKernel(base));
}
+ // float16() is not part of PrimitiveTypes() (FloatingPointTypes() only
covers
Review Comment:
Added `float16` to `FloatingPointTypes()` in #51330. Once this PR is merged,
we can verify that the updated type list works correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
