etseidl commented on code in PR #11051:
URL: https://github.com/apache/arrow-rs/pull/11051#discussion_r4007274628
##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -104,14 +117,16 @@ pub(crate) mod private {
fn get_encoder<T: DataType<T = Self>>(
descr: &ColumnDescPtr,
encoding: Encoding,
+ delta_options: Option<DeltaBinaryPackedEncoderOptions>,
) -> Result<Box<dyn Encoder<T>>> {
- get_encoder_default(descr, encoding)
+ get_encoder_default(descr, encoding, delta_options)
}
}
fn get_encoder_default<T: DataType>(
descr: &ColumnDescPtr,
encoding: Encoding,
+ delta_options: Option<DeltaBinaryPackedEncoderOptions>,
Review Comment:
```suggestion
options: Option<&ResolvedColumnProperties>,
```
here too
##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -104,14 +117,16 @@ pub(crate) mod private {
fn get_encoder<T: DataType<T = Self>>(
descr: &ColumnDescPtr,
encoding: Encoding,
+ delta_options: Option<DeltaBinaryPackedEncoderOptions>,
Review Comment:
```suggestion
options: Option<&ResolvedColumnProperties>,
```
I think we should simply push `ResolvedColumnProperties` all the way down,
and extract the delta options where relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
