emecii commented on code in PR #11051:
URL: https://github.com/apache/arrow-rs/pull/11051#discussion_r4008777816
##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -104,14 +117,16 @@ pub(crate) mod private {
fn get_encoder<T: DataType<T = Self>>(
descr: &ColumnDescPtr,
encoding: Encoding,
+ delta_options: Option<DeltaBinaryPackedEncoderOptions>,
Review Comment:
Applied both suggestions in 5cd07db. The trait dispatch (including the float
overrides) and `get_encoder_default` now take
`Option<&ResolvedColumnProperties>`, with delta options extracted only in the
three delta encoding branches. The public `get_encoder` signature and validated
constructors are unchanged. Added coverage for default byte equivalence and
unaffected float dispatch; all-feature Parquet tests, doctests, and strict
Clippy pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
