dkp116 opened a new pull request, #51382:
URL: https://github.com/apache/arrow/pull/51382

   
   ### Rationale for this change
   Add an UnsafeAppend method to FixedSizeListBuilder.
   
   UnsafeAppendNull and, consequently, UnsafeAppendNulls require more work to 
implement correctly. The safe implementation of AppendNull also appends nulls 
to the child builder through value_builder_->AppendNulls(). This makes it 
difficult to share the implementation with the unsafe path.
   
   Some child ArrayBuilder implementations use Reserve() internally, which 
returns a status rather than being a void operation. Since the purpose of the 
unsafe API is to avoid error handling and return-status propagation, directly 
sharing this implementation would defeat the purpose of the unsafe function.
   
   Therefore, this change only adds UnsafeAppend for now. The unsafe 
null-append variants can be addressed separately with the necessary changes to 
the child-builder APIs.
   
   ### What changes are included in this PR?
   Add an UnsafeAppend method to FixedSizeListBuilder.
   
   ### Are these changes tested?
   Yes in cpp/src/arrow/array/array_list_test.cc - TestAppend
   
   ### Are there any user-facing changes?
   No
   
   ### Was AI used for this PR?
   
   **PR code and description written by:**
   
   - [ X] Human - AI used to phrase the rationale better.
   - [ ] AI
   
   **Reviewed before submission by:**
   
   - [X ] Human
   - [ ] AI
   - [ ] Not reviewed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to