pitrou commented on code in PR #51382:
URL: https://github.com/apache/arrow/pull/51382#discussion_r4060117190
##########
cpp/src/arrow/array/array_list_test.cc:
##########
@@ -1600,6 +1600,15 @@ class TestFixedSizeListArray : public ::testing::Test {
std::shared_ptr<FixedSizeListArray> result_;
};
+TEST_F(TestFixedSizeListArray, TestAppend) {
+ ASSERT_OK(builder_->Append());
Review Comment:
Why not check `UnsafeAppend` directly?
(note you also need to append to the child array)
##########
cpp/src/arrow/array/builder_nested.h:
##########
@@ -725,6 +725,8 @@ class ARROW_EXPORT FixedSizeListBuilder : public
ArrayBuilder {
return std::numeric_limits<FixedSizeListType::offset_type>::max() - 1;
}
+ void UnsafeAppend();
Review Comment:
Let's perhaps inline the function implementation here? Also add a docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
