tadeja commented on code in PR #48914:
URL: https://github.com/apache/arrow/pull/48914#discussion_r4062289944
##########
cpp/src/arrow/compute/kernels/base_arithmetic_internal.h:
##########
@@ -468,6 +469,172 @@ struct FloatingDivideChecked {
// TODO: Add decimal
};
+// Remainder (truncated): result has same sign as dividend (C/C++ semantics)
+struct Remainder {
Review Comment:
@fangchenli do you perhaps have the chance to continue and look into
deduplicating (per @rok's sketch above) and add other nits? Or let me know if I
may try to give it a go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
