fangchenli commented on code in PR #48914:
URL: https://github.com/apache/arrow/pull/48914#discussion_r4066720781
##########
cpp/src/arrow/util/int_util_overflow.h:
##########
@@ -137,6 +137,25 @@ template <typename Int>
return false;
}
+template <typename Int>
+[[nodiscard]] bool ModuloWithOverflowGeneric(Int u, Int v, Int* out) {
Review Comment:
Yes, indirectly: the NON_GENERIC_OPS_WITH_OVERFLOW(ModuloWithOverflow) macro
generates wrappers that call it via ##Generic, and RemainderImpl uses those.
Same as DivideWithOverflowGeneric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
