Reranko05 commented on code in PR #51038:
URL: https://github.com/apache/arrow/pull/51038#discussion_r4065776382


##########
cpp/src/arrow/json/parser.cc:
##########
@@ -48,13 +45,30 @@ using internal::checked_cast;
 
 namespace json {
 
-namespace rj = arrow::rapidjson;
+namespace sj = simdjson::ondemand;
 
 template <typename... T>
 static Status ParseError(T&&... t) {
   return Status::Invalid("JSON parse error: ", std::forward<T>(t)...);
 }
 
+static std::string_view TrimTrailingWhitespace(std::string_view value) {

Review Comment:
   Added a common helper `ConsumeJsonWhitespace()` in `simdjson_internal.cc` 
now both `chunker.cc` and `parser.cc` call that helper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to