Reranko05 commented on code in PR #51038:
URL: https://github.com/apache/arrow/pull/51038#discussion_r4066157820
##########
cpp/src/arrow/json/parser.cc:
##########
@@ -980,96 +1106,7 @@ class Handler<UnexpectedFieldBehavior::Ignore> : public
HandlerBase {
return DoParse(*this, json);
}
- bool Null() {
- if (Skipping()) {
- return true;
- }
- return HandlerBase::Null();
- }
-
- bool Bool(bool value) {
- if (Skipping()) {
- return true;
- }
- return HandlerBase::Bool(value);
- }
-
- bool RawNumber(const char* data, rj::SizeType size, ...) {
- if (Skipping()) {
- return true;
- }
- return HandlerBase::RawNumber(data, size);
- }
-
- bool String(const char* data, rj::SizeType size, ...) {
- if (Skipping()) {
- return true;
- }
- return HandlerBase::String(data, size);
- }
-
- bool StartObject() {
- ++depth_;
- if (Skipping()) {
- return true;
- }
- return HandlerBase::StartObject();
- }
-
- /// \ingroup rapidjson-handler-interface
- ///
- /// if an unexpected field is encountered, skip until its value has been
consumed
- bool Key(const char* key, rj::SizeType len, ...) {
- MaybeStopSkipping();
- if (Skipping()) {
- return true;
- }
- bool duplicate_keys = false;
- if (ARROW_PREDICT_TRUE(
- SetFieldBuilder(std::string_view(key, len), &duplicate_keys))) {
- return true;
- }
- if (ARROW_PREDICT_FALSE(duplicate_keys)) {
- return false;
- }
- skip_depth_ = depth_;
- return true;
- }
-
- bool EndObject(...) {
- MaybeStopSkipping();
- --depth_;
- if (Skipping()) {
- return true;
- }
- return HandlerBase::EndObject();
- }
-
- bool StartArray() {
- if (Skipping()) {
- return true;
- }
- return HandlerBase::StartArray();
- }
-
- bool EndArray(rj::SizeType size) {
- if (Skipping()) {
- return true;
- }
- return HandlerBase::EndArray(size);
- }
-
- private:
- bool Skipping() { return depth_ >= skip_depth_; }
-
- void MaybeStopSkipping() {
- if (skip_depth_ == depth_) {
- skip_depth_ = std::numeric_limits<int>::max();
- }
- }
-
- int depth_ = 0;
- int skip_depth_ = std::numeric_limits<int>::max();
+ Status HandleUnexpectedField(std::string_view, sj::value) { return
Status::OK(); }
Review Comment:
Addressed. Added the test and used `ConsumeJsonValue()` in Ignored case to
catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
