AnuragRaut08 commented on code in PR #51357:
URL: https://github.com/apache/arrow/pull/51357#discussion_r4074025267
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2038,6 +2040,7 @@ Status
TypedColumnWriterImpl<ParquetType>::WriteArrowDictionary(
// had so we need to recompute it from def levels.
MaybeCalculateValidityBits(AddIfNotNull(def_levels, offset), batch_size,
&batch_num_values, &batch_num_spaced_values,
&null_count);
+ const int64_t total_null_count = batch_size - batch_num_values;
Review Comment:
Addressed, added dictionary coverage for V1/V2 with statistics and read-back
validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
