Rich-T-kid commented on code in PR #11160:
URL: https://github.com/apache/arrow-rs/pull/11160#discussion_r4095454927
##########
arrow-schema/src/datatype_parse.rs:
##########
@@ -611,10 +636,20 @@ impl<'a> Parser<'a> {
);
let (run_ends, values) = if verbose {
- let run_ends = self.parse_ree_verbose_field()?;
+ let name = self.parse_double_quoted_string("RunEndEncoded run_ends
field")?;
+ self.expect_token(Token::Colon)?;
+ let nullable = self.parse_opt_nullable();
+ if nullable {
+ return Err(make_error(
+ self.val,
+ "RunEndEncoded run_ends field cannot be nullable",
+ ));
+ }
+ let re_type = self.parse_next_type()?;
+ let run_ends = Field::new(name, re_type, false);
self.expect_token(Token::Comma)?;
- let values = self.parse_ree_verbose_field()?;
- (run_ends.with_nullable(false), values)
+ let values = self.parse_field()?;
+ (run_ends, values)
} else {
self.parse_opt_nullable(); // run_ends is always non-null; consume
the token if present
Review Comment:
yeah makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
