Jefffrey commented on code in PR #11160:
URL: https://github.com/apache/arrow-rs/pull/11160#discussion_r4100091359
##########
arrow-schema/src/datatype.rs:
##########
@@ -427,6 +432,10 @@ pub enum DataType {
///
/// These child arrays are prescribed the standard names of "run_ends" and
"values"
/// respectively.
+ ///
+ /// # Requirements
+ /// - The run_ends [`Field`] (first argument) must be non-nullable and of
type
+ /// [`DataType::Int16`], [`DataType::Int32`], or [`DataType::Int64`].
Review Comment:
thanks for adding this, it made me realize this key type is something else
to check as well. though this PR has gone through so many iterations we can do
it in a follow up (not to mention I think for dictionary we dont check key type
either yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
