kou commented on code in PR #51280:
URL: https://github.com/apache/arrow/pull/51280#discussion_r4127016980


##########
dev/tasks/linux-packages/apache-arrow/debian/control.in:
##########
@@ -26,6 +26,7 @@ Build-Depends:
   libssl-dev,
   libthrift-dev,
   libutf8proc-dev,
+  libxml2-dev,

Review Comment:
   You're right! `libxml2-dev` is already installed as a dependency.
   
   But could you install `libxml2-dev` explicitly to align this configuration? 
Other `Build-Depends` are installed explicitly.
   
   The following change will work:
   
   ```diff
   diff --git 
a/dev/tasks/linux-packages/apache-arrow/apt/debian-forky/Dockerfile 
b/dev/tasks/linux-packages/apache-arrow/apt/debian-forky/Dockerfile
   index 674e16d705..d9246d37c9 100644
   --- a/dev/tasks/linux-packages/apache-arrow/apt/debian-forky/Dockerfile
   +++ b/dev/tasks/linux-packages/apache-arrow/apt/debian-forky/Dockerfile
   @@ -68,6 +68,7 @@ RUN \
        libssl-dev \
        libthrift-dev \
        libutf8proc-dev \
   +    libxml2-dev \
        libxxhash-dev \
        libzstd-dev \
        llvm-dev \
   diff --git 
a/dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile 
b/dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile
   index 2c99276841..66548e8c2f 100644
   --- a/dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile
   +++ b/dev/tasks/linux-packages/apache-arrow/apt/debian-trixie/Dockerfile
   @@ -68,6 +68,7 @@ RUN \
        libssl-dev \
        libthrift-dev \
        libutf8proc-dev \
   +    libxml2-dev \
        libxxhash-dev \
        libzstd-dev \
        llvm-dev \
   diff --git 
a/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile 
b/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile
   index 644bc695bb..a5b732689b 100644
   --- a/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile
   +++ b/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-jammy/Dockerfile
   @@ -60,6 +60,7 @@ RUN \
        libssl-dev \
        libthrift-dev \
        libutf8proc-dev \
   +    libxml2-dev \
        libxxhash-dev \
        libzstd-dev \
        llvm-dev \
   diff --git 
a/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile 
b/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile
   index 496609a892..7e9119d313 100644
   --- a/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile
   +++ b/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-noble/Dockerfile
   @@ -61,6 +61,7 @@ RUN \
        libssl-dev \
        libthrift-dev \
        libutf8proc-dev \
   +    libxml2-dev \
        libxxhash-dev \
        libzstd-dev \
        llvm-dev \
   diff --git 
a/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-resolute/Dockerfile 
b/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-resolute/Dockerfile
   index 19f1434b7f..b1bc2f4dd1 100644
   --- a/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-resolute/Dockerfile
   +++ b/dev/tasks/linux-packages/apache-arrow/apt/ubuntu-resolute/Dockerfile
   @@ -61,6 +61,7 @@ RUN \
        libssl-dev \
        libthrift-dev \
        libutf8proc-dev \
   +    libxml2-dev \
        libxxhash-dev \
        libzstd-dev \
        llvm-dev \
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to